So, the core part for this (one) CR is done. I'll commit this after my
other CR is committed (easier for me).
Comment inline.
At 11:47 AM 10/24/2006, Greg Wright wrote:
+ free(m_pGaintoolBuffer);
+ m_pGaintoolBuffer = NULL;
You may find it easier to do HX_FREE(m_pGaintoolBuffer). If you are in
the habit of using the HX_* macros, it is much harder to forget to
NULL a member var out.
Thanks. I changed it to use HX_FREE().
If HELIX_FEATURE_GAINTOOL is not defined, do we revert to the old
behavior? Some mobile builds will not include HELIX_FEATURE_GAINTOOL
but will use ALSA.
Yes.
+ free(pOrig);
+ m_nGaintoolBufferLength = 0;
It is always good practice to NULL out a free'ed var (pOrig=NULL).
pOrig is a local variable. The original member variable is NULL-ed in this
case when realloc() returned NULL.
+HXBOOL gainIsSteadyState(GAIN_STATE* g);
+
you cold make that inline....
I would agree except that in this case, GAIN_STATE is a hidden struct
defined in gain.c, so gain.h doesn't know the fields in the struct.
--greg.
--
Daniel Yek
_______________________________________________
Audio-dev mailing list
[email protected]
http://lists.helixcommunity.org/mailman/listinfo/audio-dev
