Changes committed to Head and 210Cays. (Had some karmic issues, thus the delay...)
Thanks all, Carol. -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of ext Eric Hyche Sent: Friday, March 03, 2006 2:11 PM To: Chen Carol.I (Nokia-TP-MSW/Dallas); [EMAIL PROTECTED]; [EMAIL PROTECTED]; [email protected] Subject: RE: [datatype-dev] CR: Passing Priority settings from MMF toDevSound-- Video Ringtone subfeature Looks good. > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > [EMAIL PROTECTED] > Sent: Friday, March 03, 2006 3:01 PM > To: [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [email protected] > Subject: [datatype-dev] CR: Passing Priority settings from MMF to > DevSound-- Video Ringtone subfeature > > This is second CR submission with updated diffs. > > -- [Update from original submission] Instead of creating an > instance > of HXCommonClassFactory in HXMMFCtrlImpl, context pointer is > obtained > by query of HXMMFStateCtrl. Support for QI of > IHXCommonClassFactory > is also added in HXMMFStateCtrl. In addition, since QI can be done > on > a context, usage of IHXPreferences is not needed and thus removed > from > the audio device code. > > I did not centralize the GetPrioritySettings() function. I don't see a > need at this time but will definitely keep this solution in mind for > future implementations. > > Thanks and best regards, > Carol. > > ============================= > > "Nokia submits this code under the terms of a commercial contribution > agreement with RealNetworks, and I am authorized to contribute this > code under said agreement." > > Modified by: > [EMAIL PROTECTED] > > Reviewed by: > [EMAIL PROTECTED], [EMAIL PROTECTED] > > Date: > 3-3-2006 > > Project: > Helix plug-in for Symbian > > Synopsis: > -- Priority settings passed to the MMF from the Client/UI needs > to be passed down to DevSound. There are two integer values in > the settings: iPriority and iPref. Currently these values are > ignored > in MMF and a default value is passed to DevSound instead. > The change will allow iPriority and iPref to be set to the desired > values, and this is required for the Video Ringtone feature to > work > properly, as Video Ringtones have a higher priority than normal > video playback and Audio Policy needs to be aware of the > difference. > > -- The MMF Controller code is changed to store priority values > through the IHXPreferences interface. The AudioDevice code (for > both > MDF and non-MDF) is modified to retrieve these saved values, and > pass them down to DevSound in place of the previous default > values. > Helix core is not affected by this implementation. > > -- [Update from original submission] Instead of creating an > instance > of HXCommonClassFactory in HXMMFCtrlImpl, context pointer is > obtained > by query of HXMMFStateCtrl. Support for QI of > IHXCommonClassFactory > is also added in HXMMFStateCtrl. In addition, since QI can be done > on > a context, usage of IHXPreferences is not needed and thus removed > from > the audio device code. > > Files Modified: > clientapps\symbianMmf\hxmmfctrlimpl.cpp > clientapps\symbianMmf\hxmmfstatectrl.cpp > > audio\device\pub\platform\symbian\audsymbian.h > audio\device\platform\symbian\audsymbian.cpp > audio\device\platform\symbian\audiosvr\audio_svr.h > audio\device\platform\symbian\audiosvr\audio_svr.cpp > audio\device\platform\symbian\audiosvr\mmf\audio_session-mmf.h > audio\device\platform\symbian\audiosvr\mmf\audio_session-mmf.cpp > > datatype\mdf\audio\dsp\mdfauddevice.h > datatype\mdf\audio\dsp\mdfauddevice.cpp > datatype\mdf\audio\dsp\mdfdevsound.h > datatype\mdf\audio\dsp\mdfdevsound.cpp > datatype\mdf\audio\dsp\Umakefil > > Files Added: > none > > Image Size and Heap Use impact: > minor > > Platforms and Profiles Build Verified: > helix-client-s60-mmf-basic, helix-client-s60-mmf-mdf-basic > > Platforms and Profiles Functionality verified: > armv5, winscw > > Branch: > hxclient_2_1_0_cayennes, head > > > <<datatype.diff>> <<clientapps.diff>> <<audio.diff>> > > _______________________________________________ Datatype-dev mailing list [EMAIL PROTECTED] http://lists.helixcommunity.org/mailman/listinfo/datatype-dev _______________________________________________ Audio-dev mailing list [email protected] http://lists.helixcommunity.org/mailman/listinfo/audio-dev
