This looks almost the same as the last diff submitted. The HXCommonClassFactory is still getting created instead of QI'd for, and GetPrioritySettings() is still duplicated (see previous comments).
Was there some mistake and the old diff got re-submitted? If not, what has changed since the last diff? (In the future when submitting multiple versions of the same change, please elaborate in the Synopsis on what has changed between submissions. This makes reviewing a lot quicker, since the reviewer doesn't have to re-review sections of the diff that haven't changed). Thanks, Eric > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > [EMAIL PROTECTED] > Sent: Tuesday, February 28, 2006 5:05 PM > To: [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [email protected] > Subject: [Audio-dev] CR: Passing Priority settings from MMF > to DevSound --Video Ringtone subfeature > > "Nokia submits this code under the terms of a commercial > contribution agreement with RealNetworks, and I am authorized > to contribute this code under said agreement." > > Modified by: > [EMAIL PROTECTED] > > Reviewed by: > > Date: > 2-28-2006 > > Project: > Helix plug-in for Symbian > > Synopsis: > -- Priority settings passed to the MMF from the Client/UI needs > to be passed down to DevSound. There are two integer values in > the settings: iPriority and iPref. Currently these values > are ignored > in MMF and a default value is passed to DevSound instead. > The change will allow iPriority and iPref to be set to > the desired > values, and this is required for the Video Ringtone > feature to work > properly, as Video Ringtones have a higher priority than normal > video playback and Audio Policy needs to be aware of the > difference. > > -- The MMF Controller code is changed to store priority values > through the IHXPreferences interface. The AudioDevice > code (for both > MDF and non-MDF) is modified to retrieve these saved values, and > pass them down to DevSound in place of the previous > default values. > Helix core is not affected by this implementation. > > > Files Modified: > clientapps\symbianMmf\hxmmfctrlimpl.cpp > > audio\device\pub\platform\symbian\audsymbian.h > audio\device\platform\symbian\audsymbian.cpp > audio\device\platform\symbian\audiosvr\audio_svr.h > audio\device\platform\symbian\audiosvr\audio_svr.cpp > audio\device\platform\symbian\audiosvr\mmf\audio_session-mmf.h > audio\device\platform\symbian\audiosvr\mmf\audio_session-mmf.cpp > > datatype\mdf\audio\dsp\mdfauddevice.h > datatype\mdf\audio\dsp\mdfauddevice.cpp > datatype\mdf\audio\dsp\mdfdevsound.h > datatype\mdf\audio\dsp\mdfdevsound.cpp > datatype\mdf\audio\dsp\Umakefil > > Files Added: > none > > Image Size and Heap Use impact: > minor > > Platforms and Profiles Build Verified: > helix-client-s60-mmf-basic, helix-client-s60-mmf-mdf-basic > > Platforms and Profiles Functionality verified: > armv5, winscw > > Branch: > hxclient_2_1_0_cayennes, head > > > <<audio.diff>> <<clientapps.diff>> <<datatype.diff>> > > _______________________________________________ Audio-dev mailing list [email protected] http://lists.helixcommunity.org/mailman/listinfo/audio-dev
