Hi Eric, Thanks for your comments.
(1) I will get context pointer from HXMMFStateCtrl and use that instead. I'll change the code and submit new diff. (2) CHXMDFAudioDevice and CHXAudioDevice are in separate modules, and are not derived from the same base class so I could not define GetPrioritySettings() in a common place. Thanks and best regards, Carol. -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Behalf Of ext Eric Hyche Sent: Wednesday, 01 March, 2006 7:23 AM To: Chen Carol.I (Nokia-TP-MSW/Dallas); [EMAIL PROTECTED]; [EMAIL PROTECTED]; [email protected] Subject: [Clientapps-dev] RE: [datatype-dev] CR: Passing Priority settingsfrom MMF to DevSound-- Video Ringtone subfeature My comments: 1) HXMMFCtrlImpl::SetPrioritySettings in clientapps/symbianMmf/hxmmfctrlimpl.cpp: void HXMMFCtrlImpl::SetPrioritySettings(const TMMFPrioritySettings& aPriority) { - // Not implemented + HXLOGL1(HXLOG_SMMF, "HXMMFCtrlImpl::SetPrioritySettings() iPriority(%d) iPref(%d)", + aPriority.iPriority, aPriority.iPref); + + // use prefs namespace (IHXPreferences helpers) to store Priority Settings to prefs + if (m_pPrefs) + { + IHXCommonClassFactory *pCCF = new HXCommonClassFactory(NULL); + if (pCCF != NULL) + { + UINT32 prio = (aPriority.iPriority <= 0) ? 0 : aPriority.iPriority; + UINT32 pref = (aPriority.iPref <= 0) ? 0 : aPriority.iPref; + prefs::Write(pCCF, m_pPrefs, "MMFPriority", prio); + prefs::Write(pCCF, m_pPrefs, "MMFPriorityPref", pref); + HXLOGL3(HXLOG_SMMF, + "HXMMFCtrlImpl::SetPrioritySettings (%u,%u) written to prefs", prio, pref); + HX_DELETE(pCCF); + } + } } Creating a whole HXCommonClassFactory for a one-off usage seems like high overhead to me. does the symbianMmf TLC not have a pointer to the client core context it could use here? 2) CHXMDFAudioDevice::GetPrioritySettings() and CHXAudioDevice::GetPrioritySettings() look identical to me. If so, shouldn't they be centralized so we don't duplicate code? Rest looks good. Eric > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > [EMAIL PROTECTED] > Sent: Tuesday, February 28, 2006 5:05 PM > To: [EMAIL PROTECTED]; > [EMAIL PROTECTED]; [email protected] > Subject: [datatype-dev] CR: Passing Priority settings from > MMF to DevSound-- Video Ringtone subfeature > > "Nokia submits this code under the terms of a commercial > contribution agreement with RealNetworks, and I am authorized > to contribute this code under said agreement." > > Modified by: > [EMAIL PROTECTED] > > Reviewed by: > > Date: > 2-28-2006 > > Project: > Helix plug-in for Symbian > > Synopsis: > -- Priority settings passed to the MMF from the Client/UI needs > to be passed down to DevSound. There are two integer values in > the settings: iPriority and iPref. Currently these values > are ignored > in MMF and a default value is passed to DevSound instead. > The change will allow iPriority and iPref to be set to > the desired > values, and this is required for the Video Ringtone > feature to work > properly, as Video Ringtones have a higher priority than normal > video playback and Audio Policy needs to be aware of the > difference. > > -- The MMF Controller code is changed to store priority values > through the IHXPreferences interface. The AudioDevice > code (for both > MDF and non-MDF) is modified to retrieve these saved values, and > pass them down to DevSound in place of the previous > default values. > Helix core is not affected by this implementation. > > > Files Modified: > clientapps\symbianMmf\hxmmfctrlimpl.cpp > > audio\device\pub\platform\symbian\audsymbian.h > audio\device\platform\symbian\audsymbian.cpp > audio\device\platform\symbian\audiosvr\audio_svr.h > audio\device\platform\symbian\audiosvr\audio_svr.cpp > audio\device\platform\symbian\audiosvr\mmf\audio_session-mmf.h > audio\device\platform\symbian\audiosvr\mmf\audio_session-mmf.cpp > > datatype\mdf\audio\dsp\mdfauddevice.h > datatype\mdf\audio\dsp\mdfauddevice.cpp > datatype\mdf\audio\dsp\mdfdevsound.h > datatype\mdf\audio\dsp\mdfdevsound.cpp > datatype\mdf\audio\dsp\Umakefil > > Files Added: > none > > Image Size and Heap Use impact: > minor > > Platforms and Profiles Build Verified: > helix-client-s60-mmf-basic, helix-client-s60-mmf-mdf-basic > > Platforms and Profiles Functionality verified: > armv5, winscw > > Branch: > hxclient_2_1_0_cayennes, head > > > <<audio.diff>> <<clientapps.diff>> <<datatype.diff>> > > _______________________________________________ Clientapps-dev mailing list [EMAIL PROTECTED] http://lists.helixcommunity.org/mailman/listinfo/clientapps-dev _______________________________________________ Audio-dev mailing list [email protected] http://lists.helixcommunity.org/mailman/listinfo/audio-dev
