Thanks Greg !

The changes are committed to HEAD.

-Rajesh.

>-----Original Message-----
>From: ext Greg Wright [mailto:[EMAIL PROTECTED] 
>Sent: Thursday, October 13, 2005 11:54 AM
>To: Rathinasamy Rajesh (Nokia-TP-MSW/Dallas)
>Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; 
>[email protected]
>Subject: Re: [Porting-symbian] [Audio-dev] CR: Symbian Audio 
>device loss detection and handling
>
>These look good for HEAD.
>--greg.
>
>
>[EMAIL PROTECTED] wrote:
>> The following changes were made to the original submission 
>(suggested 
>> by Henry Ping & Greg)
>> 
>> * Removed the ifdef of MMF in audio device.
>> * Filtered the audiodevicetaken error in clientapps\symbianplayer
>> 
>> Thanks,
>> Rajesh.
>> 
>> 
>> 
>>> -----Original Message-----
>>> From: ext Greg Wright [mailto:[EMAIL PROTECTED]
>>> Sent: Tuesday, October 11, 2005 5:06 PM
>>> To: Rathinasamy Rajesh (Nokia-TP-MSW/Dallas)
>>> Cc: [email protected]
>>> Subject: Re: [Audio-dev] CR: Symbian Audio device loss 
>detection and 
>>> handling(MMF profile)
>>>
>>>
>>>>> Perhaps you could just mask the code in 
>clientapps/symbianplayer (a 
>>>>> quick hack is fine) and then we could remove all the 
>#ifdefs right?
>>>>> Is all the new code you added available in 7.0s and beyond?
>>>> Yeah ! The new code has been tested on 70s-emulator and
>>> thumb. Since I
>>>> had checked in this code under MMF profile, I might have to
>>> remove the
>>>> defines and resubmit it.
>>>>
>>>> I can change the severity level to HXLOG_INFO and this can
>>> be filtered
>>>> in clientapps\symbianplayer.
>>>>
>>>> Provided if this is ok for u, I can go ahead and resubmit 
>the CR by 
>>>> masking the error in clientapps\symbianplayer.
>>> That would be great, thanks a lot.
>>>
>>> --greg.
>>>
>>>
>>>
>>>> -Rajesh.
>>>>
>>>>
>>>>> --greg.
>>>>>
>>>
>>> 
>---------------------------------------------------------------------
>>> ---
>>>
>>> _______________________________________________
>>> Porting-symbian mailing list
>>> [EMAIL PROTECTED]
>>> http://lists.helixcommunity.org/mailman/listinfo/porting-symbian
>

_______________________________________________
Audio-dev mailing list
[email protected]
http://lists.helixcommunity.org/mailman/listinfo/audio-dev

Reply via email to