Looks good. > -----Original Message----- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Greg Wright > Sent: Wednesday, April 20, 2005 7:25 PM > To: [EMAIL PROTECTED]; > [email protected] > Subject: [Audio-dev] CR-Client: Fix symbian audio crash. > > Fixes and /0 crash in the audio code. > Symbian only. > HEAD, 150Cay, 201Cay. > > Seems some clips, like: > > rtsp://mmsdemo-05.real.com/VF_GUIDE/edge/monstersinc_208x136_e > dge_35k.rm > > will cause this. Not sure why. But it can also lead to some sort over > audio server startup deadlock. Anyway, always good to not /0. > > --greg. > > > > Index: platform/symbian/audiosvr/mmf/audio_session-mmf.cpp > =================================================================== > RCS file: > /cvsroot/audio/device/platform/symbian/audiosvr/mmf/audio_sess > ion-mmf.cpp,v > retrieving revision 1.4.2.5 > diff -u -w -r1.4.2.5 audio_session-mmf.cpp > --- platform/symbian/audiosvr/mmf/audio_session-mmf.cpp 20 > Apr 2005 03:22:48 -0000 1.4.2.5 > +++ platform/symbian/audiosvr/mmf/audio_session-mmf.cpp 20 > Apr 2005 23:19:04 -0000 > @@ -681,7 +681,11 @@ > cbBuffered += m_cbBufferList - m_cbFrontBufferWritten; > > // convert bytes to block count (rounded up) > - TUint32 blockCount = cbBuffered/m_cbBlock + 1; > + TUint32 blockCount = 0; > + if( m_cbBlock != 0 ) > + { > + blockCount = cbBuffered/m_cbBlock + 1; > + } > > HXLOGL4(HXLOG_ADEV, > "HXSymbianAudioSession::GetBlocksBuffered(): block count = > %lu (%lu bytes total; %lu in list)", > blockCount, cbBuffered, m_cbBufferList); > > @@ -1056,7 +1060,7 @@ > > _______________________________________________ > Audio-dev mailing list > [email protected] > http://lists.helixcommunity.org/mailman/listinfo/audio-dev >
_______________________________________________ Audio-dev mailing list [email protected] http://lists.helixcommunity.org/mailman/listinfo/audio-dev
