At 10:18 AM 4/13/2005 -0700, Greg Wright wrote:
For now the code assumes a 6630 but in order to support other
> devices we will probably need to add a run-time check on the device
> id so this works on non-OMAP based devices.

Does this mean this code will not run on phones like the 3650? We still
need to support older Series60 devices on the 150Cay branch.

I think but am not sure this will not run on non-OMAP phones (3650 and 6620).

I'll look at getting the device id for the 6630.


+#if (0)
 static TInt FlagToNumber(TMMFSampleRate flag)
 {
     switch( flag )
@@ -186,9 +179,10 @@
     default:
         break;
     }
-    HX_ASSERT(false);
+    HX_ASSERT(FALSE);
     return 0;
 }
+#endif

Are we going to use this #if 0 code later?

No. I'll take it out.


+        static const TInt KClientPriority = 69;
+
     // set priority.
     TMMFPrioritySettings prioritySettings;
-    prioritySettings.iPref     = KPriorityPref;
+        prioritySettings.iPref     = EMdaPriorityPreferenceTime;
     prioritySettings.iPriority = KClientPriority;
     prioritySettings.iState    = EMMFStatePlaying;
     m_pStream->SetPrioritySettings(prioritySettings);
+    }

What is priority 69 and is this changing from the old one?

The 69 was determined a while back based on feedback from Nokia for the 3650. I'm not sure this is still the ideal value but it is the same as we've had all along. I just moved the constant close to the one and only place it is used. We are using the same priority settings as before.


Thanks,

Liam


rest looks good.

--greg.


_______________________________________________
Audio-dev mailing list
[email protected]
http://lists.helixcommunity.org/mailman/listinfo/audio-dev

Reply via email to