----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/868/#review2626 -----------------------------------------------------------
Ship it! - Russell On 2010-08-19 23:57:22, elguero wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/868/ > ----------------------------------------------------------- > > (Updated 2010-08-19 23:57:22) > > > Review request for Asterisk Developers. > > > Summary > ------- > > It would appear that with the merge of the rtp_engine api, the tos is no > longer being set on RTP packets through res_rtp_asterisk. Also, chan_sip is > not setting the cos on RTP packets. > > The attached patch restores setting the tos on rtp packets. > > The patch also sets cos on rtp packets using chan_sip. > > > This addresses bug 17890. > https://issues.asterisk.org/view.php?id=17890 > > > Diffs > ----- > > /branches/1.8/channels/chan_sip.c 282960 > /branches/1.8/res/res_rtp_asterisk.c 282960 > > Diff: https://reviewboard.asterisk.org/r/868/diff > > > Testing > ------- > > Using wireshark on machine running centos 5.5 - trunk and another machine > running fedora 13 - trunk, confirmed that RTP tos was not being set. > > Patched the fedora 13 machine, confirmed with wireshark that tos was being > set only on rtp packets from fedora 13 machine to centos 5.5 machine. > Patched the centos 5.5 machine and saw all rtp packets being set with qos. > > > Thanks, > > elguero > > -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-security mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-security
