> On April 20, 2015, 1:40 p.m., Matt Jordan wrote: > > Over the past week, Asterisk has moved to Git. The migration was announced > > and discussed on the asterisk-dev list. > > > > We are now using Gerrit for code reviews (gerrit.asterisk.org). You can > > find instructions for using Gerrit on the Asterisk wiki: > > > > https://wiki.asterisk.org/wiki/display/AST/Gerrit+Usage > > > > Information about the Git servers and other policies can be found here: > > > > https://wiki.asterisk.org/wiki/display/AST/Git+Usage > > > > While it's a bit of a pain to move the patch over, in the long run, this > > should make managing the clang fixup patches much easier. > > Diederik de Groot wrote: > Hi Matt, > > Thanks for the heads up. Will make the move to Git + Gerrit. From what i > read on the mailinglist posts i though you were still experimenting. I guess > I missed the final move announcement :-) > > BTW: This is the last series of small patches that would be required to > get clang compilation finished. So we are almost there.
Moved to git + gerrit https://gerrit.asterisk.org/#/c/157 https://gerrit.asterisk.org/#/c/158 https://gerrit.asterisk.org/#/c/159 https://gerrit.asterisk.org/#/c/160 Closing this review - Diederik ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4613/#review15197 ----------------------------------------------------------- On April 20, 2015, 12:38 p.m., Diederik de Groot wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4613/ > ----------------------------------------------------------- > > (Updated April 20, 2015, 12:38 p.m.) > > > Review request for Asterisk Developers, Matt Jordan, Mark Michelson, and > rmudgett. > > > Bugs: ASTERISK-24917 > https://issues.asterisk.org/jira/browse/ASTERISK-24917 > > > Repository: Asterisk > > > Description > ------- > > clang compilation. > > three warnings have been suppressed (in Makefile.rules), which were deemed > unsuitable for asterisk: > - unused-value > - parentheses-equality > - unused-command-line-argument > > changes can/could be ported back to asterisk-11 if required. > > > Diffs > ----- > > /branches/13/res/res_security_log.c 434725 > /branches/13/makeopts.in 434725 > /branches/13/main/security_events.c 434725 > /branches/13/include/asterisk/utils.h 434725 > /branches/13/include/asterisk/autoconfig.h.in 434725 > /branches/13/contrib/scripts/clang-scan-build PRE-CREATION > /branches/13/configure.ac 434725 > /branches/13/configure UNKNOWN > /branches/13/channels/chan_skinny.c 434725 > /branches/13/autoconf/ast_check_strsep_array_bounds.m4 PRE-CREATION > /branches/13/autoconf/ast_check_raii.m4 PRE-CREATION > /branches/13/Makefile.rules 434725 > > Diff: https://reviewboard.asterisk.org/r/4613/diff/ > > > Testing > ------- > > compiles cleanly > > test execute all > 455 Test(s) Executed 454 Passed 1 Failed > > FAIL test_message_queue_handler_nom /main/message/ 21200ms > ===== > START /main/message/ - test_message_queue_handler_nominal > [test_message.c:int handler_wait_for_message(struct ast_test *):244]: Test > timed out while waiting for handler to get message > END /main/message/ - test_message_queue_handler_nominal Time: 21241ms > Result: FAIL > ===== > 1 Test(s) Executed 0 Passed 1 Failed > == Message handler 'testmsg' registered. > -- Executing [s@default:1] wait("Message/ast_msg_queue", "1") > -- Executing [s@default:1] answer("Message/ast_msg_queue", "") > -- Digit timeout set to 5.000 > -- Response timeout set to 10.000 > > .... > -- Executing [s@default:1] background("Message/ast_msg_queue", > "demo-congrats") > [Apr 18 15:22:50] ERROR[13650][C-00000000]: channel.c:5423 int > set_format(struct ast_channel *, struct ast_format_cap *, const int): Unable > to set format because channel Message/ast_msg_queue supports no formats > [Apr 18 15:22:50] WARNING[13650][C-00000000]: file.c:1100 int > ast_streamfile(struct ast_channel *, const char *, const char *): Unable to > open demo-congrats (format (none)): Function not implemented > [Apr 18 15:22:50] WARNING[13650][C-00000000]: pbx.c:11319 int > pbx_builtin_background(struct ast_channel *, const char *): ast_streamfile > failed on Message/ast_msg_queue for demo-congrats > .... Repeated.... > > > Thanks, > > Diederik de Groot > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
