-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4543/
-----------------------------------------------------------
(Updated March 29, 2015, 2:57 p.m.)
Review request for Asterisk Developers.
Changes
-------
Ran clang's static analyzer which found 819 of potential issues, some of which
are real bugs and of course some are also false positives. Adding both clang
and scan-build to a CI environment could be quite helpfull in tracking down
these bugs. The scanbuild file is pretty bif (sorry about that), but it
includes the branching path that leads up to the bug.
Bugs: ASTERISK-24917
https://issues.asterisk.org/jira/browse/ASTERISK-24917
Repository: Asterisk
Description
-------
RAII-clang reentrancy / Updating variable from inside a _block
To update the varname variable from inside the cleanup block it needs to be
decorated with "__block" as in:
__block vartype varname = ctor;
Diffs
-----
/branches/13/include/asterisk/utils.h 433444
/branches/13/contrib/scan-build PRE-CREATION
/branches/13/configure.ac 433444
/branches/13/autoconf/ast_check_raii.m4 PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4543/diff/
Testing
-------
File Attachments (updated)
----------------
scanbuild output
https://reviewboard.asterisk.org/media/uploaded/files/2015/03/29/5417a9e0-0023-4eb2-aa97-5a2659997e68__scanbuild_2015-03-29_r433715.tar.bz2
Thanks,
Diederik de Groot
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
