----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4535/#review14937 -----------------------------------------------------------
Ship it! I'd say close out the findings just so the review shows that everything was addressed. Thanks for cleaning this up! - Matt Jordan On March 26, 2015, 5:55 p.m., Diederik de Groot wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4535/ > ----------------------------------------------------------- > > (Updated March 26, 2015, 5:55 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24917 > https://issues.asterisk.org/jira/browse/ASTERISK-24917 > > > Repository: Asterisk > > > Description > ------- > > clang's static analyzer will throw quite a number warnings / errors during > compilation, some of which can be very helpfull in finding corner-case > bugs\nclang compiler warning:-Wenum-conversion > > > Diffs > ----- > > /branches/13/res/res_stasis.c 433444 > /branches/13/main/strings.c 433444 > /branches/13/include/asterisk/strings.h 433444 > /branches/13/channels/chan_sip.c 433444 > /branches/13/channels/chan_pjsip.c 433444 > > Diff: https://reviewboard.asterisk.org/r/4535/diff/ > > > Testing > ------- > > > Thanks, > > Diederik de Groot > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
