> On March 12, 2015, 5:57 p.m., Mark Michelson wrote: > > /trunk/main/dns_core.c, lines 285-290 > > <https://reviewboard.asterisk.org/r/4474/diff/1/?file=71973#file71973line285> > > > > I was taking another look at this review and realized that there is > > nothing here to ensure that we do not wait forever for a response to our > > DNS query. Is it the responsibility of the resolver to time out > > appropriately, or should some core timeout be implemented so that the query > > may be canceled at this level if the query takes too long?
It's currently the responsibility of the resolver. - Joshua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/#review14660 ----------------------------------------------------------- On March 11, 2015, 11:42 a.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4474/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 11:42 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24834 > https://issues.asterisk.org/jira/browse/ASTERISK-24834 > > > Repository: Asterisk > > > Description > ------- > > This change implements the basic API as described on the DNS API wiki page. > Minimal changes have been made as required based on real usage and getting a > feel for it. As it is the core functionality is present. Resolvers can > register, queries can be made (async / sync). > > As the API was basically copy/pasted from the wiki page there still remain > stubs to be filled in for higher level functionality (such as parsing and > query sets). > > > Diffs > ----- > > /trunk/main/dns_query_set.c PRE-CREATION > /trunk/main/dns_core.c PRE-CREATION > /trunk/include/asterisk/dns_tlsa.h PRE-CREATION > /trunk/include/asterisk/dns_srv.h PRE-CREATION > /trunk/include/asterisk/dns_resolver.h PRE-CREATION > /trunk/include/asterisk/dns_recurring.h PRE-CREATION > /trunk/include/asterisk/dns_query_set.h PRE-CREATION > /trunk/include/asterisk/dns_naptr.h PRE-CREATION > /trunk/include/asterisk/dns_internal.h PRE-CREATION > /trunk/include/asterisk/dns_core.h PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4474/diff/ > > > Testing > ------- > > Ran DNS unit tests as done by Mark, they are happy. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
