> On March 9, 2015, 6:29 p.m., Mark Michelson wrote: > > /branches/13/main/config.c, lines 1252-1260 > > <https://reviewboard.asterisk.org/r/4468/diff/1/?file=71929#file71929line1252> > > > > Handling the possibility of cloned being NULL is necessary, but the > > problem with just returning here is that it leaves new in a half-altered > > state. > > > > I think the way to do this is to perform all necessary allocations up > > front and then perform the necessary changes to new once they have all > > succeeded.
This is a difficult issue, I think ast_category_inherit needs to return an int (success/failure). Consider that an admin puts [somepeer](sometemplate) into a config. [somepeer] is invalid / failed to load unless sometemplate was applied 100% successfuly. Anything less and the values in [somepeer] cannot be trusted. For example sometemplate could have NAT settings, IP restrictions, etc. - Corey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4468/#review14618 ----------------------------------------------------------- On March 9, 2015, 4:50 p.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4468/ > ----------------------------------------------------------- > > (Updated March 9, 2015, 4:50 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Using the CHAOS random failure mechanism > (https://reviewboard.asterisk.org/r/4463/) I uncovered several possibilities > of a crash on null pointer, and one uninitialized variable that allowed > ast_random to lock up if used before utils init. > > Additionally, extra output to determine why Asterisk failed to initialize has > been added. > > > Diffs > ----- > > /branches/13/main/xmldoc.c 432661 > /branches/13/main/utils.c 432661 > /branches/13/main/endpoints.c 432661 > /branches/13/main/config.c 432661 > /branches/13/main/codec_builtin.c 432661 > /branches/13/main/asterisk.c 432661 > > Diff: https://reviewboard.asterisk.org/r/4468/diff/ > > > Testing > ------- > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
