----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4409/#review14434 -----------------------------------------------------------
Ship it! Ship It! - Joshua Colp On Feb. 7, 2015, 12:25 a.m., Kevin Harwell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4409/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2015, 12:25 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24741 > https://issues.asterisk.org/jira/browse/ASTERISK-24741 > > > Repository: Asterisk > > > Description > ------- > > There have been a couple of times where a crash occurred in the dtls_handler > section of the code for res_pjsip. Unfortunately, in working this issue the > problem was unable to be reproduced. After looking at the backtraces and > through the code the current best guess as to why this happened might be due > to a reentrance problem and the strtok function. So, the current fix is to > convert the strtok function into the reentrant version of the function, > strtok_r. > > > Diffs > ----- > > branches/13/res/res_pjsip/pjsip_configuration.c 431572 > > Diff: https://reviewboard.asterisk.org/r/4409/diff/ > > > Testing > ------- > > Ran through the pjsip testsuite tests to make sure no crashes occurred or > anything else out of the ordinary. Also while running asterisk with res_pjsip > configured to use realtime issued reloads every 0.1 seconds while also > executing the show endpoint command at the same interval in an attempt to > potentially cause two threads to enter the dtls_handler function at the same > time. No crashes occurred. > > > Thanks, > > Kevin Harwell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
