> On Jan. 12, 2015, 1:57 p.m., Mark Michelson wrote: > > /asterisk/trunk/tests/apps/macro/redirect_inside/test-config.yaml, lines > > 50-52 > > <https://reviewboard.asterisk.org/r/4319/diff/2/?file=70460#file70460line50> > > > > Should one of these be uncommented?
Not really. There is only one exten in that macro context, which header is available is version dependent and the "Extension" header might eventually dissapear in favor of the "Exten" header. - rmudgett ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4319/#review14161 ----------------------------------------------------------- On Jan. 9, 2015, 3:20 p.m., rmudgett wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4319/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 3:20 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23850 > https://issues.asterisk.org/jira/browse/ASTERISK-23850 > > > Repository: testsuite > > > Description > ------- > > Test channel redirect when a macro is active. > 1) Redirect while in an active macro to an external dialplan location. > 2) Redirect while in an active macro to an extension in the macro context. > 3) Park while in an active macro and timeout to an external dialplan location. > 4) Park while in an active macro and timeout to an extension in the macro > context. > > > Diffs > ----- > > /asterisk/trunk/tests/apps/tests.yaml 6226 > /asterisk/trunk/tests/apps/macro/tests.yaml PRE-CREATION > /asterisk/trunk/tests/apps/macro/redirect_outside/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/apps/macro/redirect_outside/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/apps/macro/redirect_inside/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/apps/macro/redirect_inside/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/apps/macro/park_timeout_outside/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/apps/macro/park_timeout_outside/configs/ast1/res_parking.conf > PRE-CREATION > > /asterisk/trunk/tests/apps/macro/park_timeout_outside/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/apps/macro/park_timeout_inside/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/apps/macro/park_timeout_inside/configs/ast1/res_parking.conf > PRE-CREATION > > /asterisk/trunk/tests/apps/macro/park_timeout_inside/configs/ast1/extensions.conf > PRE-CREATION > > Diff: https://reviewboard.asterisk.org/r/4319/diff/ > > > Testing > ------- > > All tests pass when the patch on review > https://reviewboard.asterisk.org/r/4292/ is applied. > Tests 2 and 4 fail when the patch is not applied. > > > Thanks, > > rmudgett > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
