-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4311/
-----------------------------------------------------------
Review request for Asterisk Developers.
Bugs: ASTERISK-24485
https://issues.asterisk.org/jira/browse/ASTERISK-24485
Repository: Asterisk
Description
-------
The res_pjsip module was previously unloadable. With this patch it can now be
unloaded.
This patch is based off the original patch on the issue by Corey Farrell with a
few modifications. Removed a few changes not required to make the module
unloadable and also fixed a bug that would cause asterisk to crash on unloading.
Diffs
-----
branches/13/res/res_pjsip/pjsip_outbound_auth.c 430178
branches/13/res/res_pjsip/pjsip_options.c 430178
branches/13/res/res_pjsip/pjsip_global_headers.c 430178
branches/13/res/res_pjsip/pjsip_distributor.c 430178
branches/13/res/res_pjsip/pjsip_configuration.c 430178
branches/13/res/res_pjsip/location.c 430178
branches/13/res/res_pjsip/include/res_pjsip_private.h 430178
branches/13/res/res_pjsip/config_transport.c 430178
branches/13/res/res_pjsip/config_auth.c 430178
branches/13/res/res_pjsip.c 430178
branches/13/main/stasis_message_router.c 430178
Diff: https://reviewboard.asterisk.org/r/4311/diff/
Testing
-------
Made it so res_pjsip was the only pjsip module loaded and then issued an unload
and noted it unloaded successfully (also loaded/unloaded it several times from
the CLI). Also when loaded and with REF_DEBUG enabled issued a "core stop
gracefully" and made sure there were no ref leaks for the module.
Also tested unloading with other dependent pjsip modules loaded and noted that
the module would not unload (as it should since dependencies are currently
loaded). And then shutdown asterisk and made sure it did not crash or anything.
Started asterisk with nominal and off nominal module and pjsip configurations
to make sure things behaved appropriately (no crashes and such) and then
attempted to, or successfully unload the res_pjsip module. Also made sure
Asterisk continued to shutdown without incident.
Thanks,
Kevin Harwell
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
