> On Dec. 17, 2014, 2:08 p.m., Mark Michelson wrote: > > /branches/12/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py, lines 590-594 > > <https://reviewboard.asterisk.org/r/4280/diff/1/?file=69819#file69819line590> > > > > I don't agree with this change. While I expect it to be rare, if > > someone had a working sip.conf file with no "bindaddr" or "udpbindaddr" > > present, this likely meant they had a TCP or TLS only setup. We shouldn't > > create a UDP transport in such a case.
Removing the default udp transport would break the default of transport=transport-udp references for converted endpoints, as the assumption is that chan_sip would always have a default bind of 0.0.0.0:5060 even if not specified. I've instead changed it to default to a null bind value to hopefully indicate to the user that they may want to revise the transport settings manually. - Scott ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4280/#review13995 ----------------------------------------------------------- On Dec. 19, 2014, 7:52 a.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4280/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2014, 7:52 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24474 > https://issues.asterisk.org/jira/browse/ASTERISK-24474 > > > Repository: Asterisk > > > Description > ------- > > General improvements to reliability of conversion utility: > > 1) track default section of input file to allow parsing an include file that > doesn't specify a [section] > > 2) informatively handle case of assignment with no section > > 3) correctly handle getting sections from included files > > 4) assume default bind of 0.0.0.0 > > 5) gracefully handle missing portions of registration string > > 6) Denote steps of operation and confirm top level conf files being > read/written as a convenience > > > Diffs > ----- > > /branches/12/contrib/scripts/sip_to_pjsip/sip_to_pjsip.py 429613 > /branches/12/contrib/scripts/sip_to_pjsip/astconfigparser.py 429613 > > Diff: https://reviewboard.asterisk.org/r/4280/diff/ > > > Testing > ------- > > Ran on config files from various sources to insure no exceptions occurred. > Perused output to confirm appearance of converted input values. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
