-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2826/
-----------------------------------------------------------
(Updated Dec. 12, 2014, 5:31 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers and Matt Jordan.
Changes
-------
Committed in revision 429539
Bugs: ASTERISK-19463
https://issues.asterisk.org/jira/browse/ASTERISK-19463
Repository: Asterisk
Description
-------
This patch corrects a consistency issue with debug threads that I
noticed while fixing ASTERISK-22455.
The initialization of a mutex's lock tracking structure was not
protected in a critical section. This is fine for any mutex that is
explicitly initialized, but a static mutex may have its lock tracking
double-initialized if multiple threads attempt the first lock
simultaneously.
This patch creates a global mutex to properly serialize the
initialization of the lock tracking structure for a mutex. It also
changes lock.c to properly handle allocation failures of the lock
tracking structure.
Diffs
-----
/branches/1.8/main/lock.c 398421
/branches/1.8/include/asterisk/lock.h 398421
Diff: https://reviewboard.asterisk.org/r/2826/diff/
Testing
-------
I propose we setup Bamboo to run the TestSuite with DEBUG_THREADS
enabled on this branch nightly for a few weeks.
Thanks,
David Lee
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
