-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4261/#review13957
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Harwell


On Dec. 12, 2014, 10:51 a.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4261/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2014, 10:51 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Persistent subscriptions are recreated successfully, but the subscription 
> handlers (e.g. MWI) do not know that the persistent subscription was 
> recreated. This is because the subscription_established() callback is not 
> called for the handler when a persistent subscription is recreated. This 
> patch corrects this by generating the "initial" NOTIFY request when a 
> persistent subscription is recreated.
> 
> This issue only affects Asterisk 13 since the bug was introduced when 13's 
> pubsub framework was refactored.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_pjsip_pubsub.c 429063 
> 
> Diff: https://reviewboard.asterisk.org/r/4261/diff/
> 
> 
> Testing
> -------
> 
> Before the patch, starting Asterisk with a persistent subscription would 
> result in a NULL-state subscription being shown by 
> PJSIPShowSubscriptionsInbound. Trying to update state on the subscription 
> would not result in NOTIFY requests being sent out on the subscription. After 
> the patch, starting Asterisk with a persistent subscription results in an 
> ACTIVE-state subscription being shown by PJSIPShowSubscriptionsInbound. 
> Trying to update state on the subscription results in NOTIFY requests being 
> sent.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

Reply via email to