On Wed, Dec 3, 2014 at 6:22 PM, James Cloos <[email protected]> wrote: >>>>>> "MJ" == Matthew Jordan <[email protected]> writes: > > MJ> Your diff appears to be invalid, per the exception being thrown by > MJ> Review Board: > > It then should note that only svn diff output works, and not git diff > from a git svn clone. > > And something better than a 500 would be nice. > > Any, it is generated: > > https://reviewboard.asterisk.org/r/4230/ > > I don't see a way there to request a review of a proposed patch for > https://github.com/asterisk/pjproject, though. > > The patch is posted on the jira issue (ASTERISK-24575). > > Is that enough? >
On the issue should be fine. Just make sure the fields in the review are all filled out, including the issue related to the review. That way reviewers can look at the pjproject patch as well. -- Matthew Jordan Digium, Inc. | Engineering Manager 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA Check us out at: http://digium.com & http://asterisk.org -- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
