> On Nov. 14, 2014, 8:12 a.m., Joshua Colp wrote: > > branches/12/res/res_pjsip_phoneprov_provider.c, line 380 > > <https://reviewboard.asterisk.org/r/4183/diff/1/?file=68985#file68985line380> > > > > Is this really needed? ast_sorcery_open calls __ast_sorcery_open with > > the module name. This then calls __ast_sorcery_apply_config internally to > > apply configuration. Is this broken/not working?
Ha! I didn't check. I saw the other res_pjsip modules had the call to apply_config and phoneprov_provider didn't but now I realize why. The others don't call open themselves so they have to explicitly call apply_config with their own module name. In the words of Emily Litella: "Nevermind" - George ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4183/#review13766 ----------------------------------------------------------- On Nov. 13, 2014, 5:34 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4183/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2014, 5:34 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24520 > https://issues.asterisk.org/jira/browse/ASTERISK-24520 > > > Repository: Asterisk > > > Description > ------- > > Add a call to ast_sorcery_apply_config so this module can configured in > sorcery.conf for realtime. > > Reported-by: John Kiniston > > > Diffs > ----- > > branches/12/res/res_pjsip_phoneprov_provider.c 427839 > > Diff: https://reviewboard.asterisk.org/r/4183/diff/ > > > Testing > ------- > > I tested that the sorcery.conf hook is getting called but can't test beyond > that right now. > > I'll get the reporter to test. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
