----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4156/#review13757 -----------------------------------------------------------
/asterisk/trunk/lib/python/asterisk/pcap.py <https://reviewboard.asterisk.org/r/4156/#comment24244> You should be able to go ahead and set the defaults here too if no option is specified for instance : module_config.get('buffer-size', 0) /asterisk/trunk/lib/python/pcap_listener.py <https://reviewboard.asterisk.org/r/4156/#comment24243> Instead of checking for None here and then setting the value just set these as the defaults on the function parameters (similar to what you did on PcapFile _init_). - Kevin Harwell On Nov. 6, 2014, 5:05 p.m., jbigelow wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4156/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 5:05 p.m.) > > > Review request for Asterisk Developers. > > > Repository: testsuite > > > Description > ------- > > This allows setting the snaplen and buffer_size for packet capturing. The > defaults set are the same as the defaults that yappcap.PcapLive sets. > > > Diffs > ----- > > /asterisk/trunk/lib/python/pcap_listener.py 5913 > /asterisk/trunk/lib/python/asterisk/test_case.py 5913 > /asterisk/trunk/lib/python/asterisk/pcap.py 5913 > > Diff: https://reviewboard.asterisk.org/r/4156/diff/ > > > Testing > ------- > > Used the options to set a lower snaplen and a higher buffer successfully. > > > Thanks, > > jbigelow > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
