----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4153/#review13710 -----------------------------------------------------------
Ship it! /branches/11/main/manager.c <https://reviewboard.asterisk.org/r/4153/#comment24205> Nit: For some reason, I find the inverted logic harder to read. How about: if (session) { if (blastaway) { session_destroy(session); } else { if (session->f) { fclose(session->f); session->f = NULL; } unref_mansession(session); } } - Matt Jordan On Nov. 6, 2014, 5:29 a.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/4153/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2014, 5:29 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-24505 > https://issues.asterisk.org/jira/browse/ASTERISK-24505 > > > Repository: Asterisk > > > Description > ------- > > Fix reference leak that happens if (session && !blastaway). > > > Diffs > ----- > > /branches/11/main/manager.c 427380 > > Diff: https://reviewboard.asterisk.org/r/4153/diff/ > > > Testing > ------- > > tests/manager/config/basic against 13. > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
