----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3975/#review13239 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On Sept. 4, 2014, 2:32 p.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3975/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2014, 2:32 p.m.) > > > Review request for Asterisk Developers and Matt Jordan. > > > Repository: Menuselect > > > Description > ------- > > This corrects a situation where menuselect can incorrectly enable a module by > default that has defaultenabled set to "no" and has failed/non-selected > dependencies. The bug is due to an inverted test when checking for whether > the given module should be set to enabled by default on load. > > > Diffs > ----- > > trunk/menuselect.c 1186 > > Diff: https://reviewboard.asterisk.org/r/3975/diff/ > > > Testing > ------- > > Verified that the four modules that fit the requirements for this bug were > correctly not enabled when the patch was applied. The modules where I > observed this behavior are pbx_ael, chan_jingle, chan_gtalk, and chan_mgcp on > the 1.8.28 certified branch. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
