----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/#review13180 -----------------------------------------------------------
branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3944/#comment23650> This line is getting long. branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3944/#comment23652> all and participants don't work very well with these messages. In the not_found case, all and participants can be "No participants found!\n" In the found case, the message could be: "Kicked %s out of conference '%s'\n" It then works for all, participants, and PJSIP/100-00000000 branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3944/#comment23653> Since this is a partial match, you need to stop before finding any more. branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3944/#comment23654> Same about partial match. branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3944/#comment23656> Match all and participants for this message. branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3944/#comment23657> Line getting long branches/12/apps/app_confbridge.c <https://reviewboard.asterisk.org/r/3944/#comment23658> Line getting long - rmudgett On Aug. 26, 2014, 12:35 p.m., George Joseph wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3944/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 12:35 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Although tab completion for confbridge mute and unmute show 'all' as a valid > channel target, it was never implemented. > > This patch updates mute and unmute (both CLI and AMI) to allow the 'all' > target. They now work as kick does. Since I was there, I made the channel > name case-insensitive since kick was already case-insensitive. > > > Diffs > ----- > > branches/12/apps/app_confbridge.c 422052 > > Diff: https://reviewboard.asterisk.org/r/3944/diff/ > > > Testing > ------- > > Tested that both CLI and AMI handle 'all' and 'participants' as a channel > target for mute, unmute and kick correctly. > > > Thanks, > > George Joseph > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
