----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3856/#review12904 -----------------------------------------------------------
/branches/11/channels/chan_iax2.c <https://reviewboard.asterisk.org/r/3856/#comment23277> Fixed sizes always bite us. I'd opt for making this zero sized and allocate the needed room to store the hostname with the reg structure itself. /branches/11/channels/chan_iax2.c <https://reviewboard.asterisk.org/r/3856/#comment23278> While here we may as well sscanf this. - Joshua Colp On July 25, 2014, 2:47 p.m., Michael Young wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3856/ > ----------------------------------------------------------- > > (Updated July 25, 2014, 2:47 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23767 > https://issues.asterisk.org/jira/browse/ASTERISK-23767 > > > Repository: Asterisk > > > Description > ------- > > The reporter on the issue found some issues when upgrading from version 10 to > 11 on 55 hosts. > > Two situations that can occur with dynamic registrations. > > 1. With dnsmgr disabled, if the host is not resolvable we are not trying to > resolve the host again when it is time to attempt to register again. > 2. With dnsmgr enabled, when the host is temporarily not resolvable the > address is set to 0.0.0.0:0 and then when the host is resolvable the port is > not being restored and stays set to 0. > > This patch resolves these two issues. > > > Diffs > ----- > > /branches/11/channels/chan_iax2.c 419562 > > Diff: https://reviewboard.asterisk.org/r/3856/diff/ > > > Testing > ------- > > This was tested on a test machine. > > The reporter of the issue also tested this and has confirmed that it solves > both issues. > > > Thanks, > > Michael Young > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
