-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3800/
-----------------------------------------------------------
(Updated July 15, 2014, 5:28 p.m.)
Review request for Asterisk Developers, Joshua Colp, Matt Jordan, and opticron.
Changes
-------
Hit the ref leak I noted.
Bugs: ASTERISK-23958
https://issues.asterisk.org/jira/browse/ASTERISK-23958
Repository: Asterisk
Description
-------
At some point in the media_formats work, the function edited in this patch was
modified in a way that left it abandoning the preference order of the codecs
and just choosing from the first value in the codecs bitfield. This patch
changes that function to evaluate using the preferred codecs order.
Diffs (updated)
-----
/team/group/media_formats-reviewed-trunk/channels/chan_iax2.c 418711
Diff: https://reviewboard.asterisk.org/r/3800/diff/
Testing
-------
[lappy]
type=friend
...
disallow = all
allow = ulaw
allow = gsm
allow = alaw
context = default
[deskbox]
type=friend
...
disallow=all
allow=gsm
allow=alaw
context = default
Using these two peers, I had each call the other.
lappy -> deskbox
Asterisk 11: Codec chosen for lappy was ulaw. Codec chosen for deskbox was
alaw, presumably because of favorable transcoding costs.
without patch: Codec chosen for both was gsm in spite of preferred order for
lappy favoring ulaw
with patch: Codec chosen for lappy was ulaw. Codec chosen for deskbox was alaw,
again presumably because of favorable transcoding costs.
deskbox -> lappy
It was GSM for both endpoints in all cases because deskbox favors gsm and lappy
supports it.
Thanks,
Jonathan Rose
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
