----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3787/ -----------------------------------------------------------
(Updated July 15, 2014, 1:49 p.m.) Review request for Asterisk Developers. Changes ------- Addressed feedback. Repository: Asterisk Description ------- There are a few places where the ref originally returned by ast_format_cache_get_slin_by_rate() is not really needed. The ast_format_cache_get_slin_by_rate() is really a convenience function to pick the best global ast_format_slinxxx value which is accessed directly throughout the code. * Simplified many uses of ast_format_cache_get_slin_by_rate() to not have to unref the format. * Added some BUGBUG comments about the translation code trashing the normal static frame setup when a special frame is needed in codec_dahdi.c and codec_speex.c. Diffs (updated) ----- /team/group/media_formats-reviewed-trunk/res/res_stasis_snoop.c 418654 /team/group/media_formats-reviewed-trunk/main/slinfactory.c 418654 /team/group/media_formats-reviewed-trunk/main/format_cache.c 418654 /team/group/media_formats-reviewed-trunk/main/channel.c 418654 /team/group/media_formats-reviewed-trunk/main/audiohook.c 418654 /team/group/media_formats-reviewed-trunk/include/asterisk/format_cache.h 418654 /team/group/media_formats-reviewed-trunk/codecs/codec_speex.c 418654 /team/group/media_formats-reviewed-trunk/codecs/codec_resample.c 418654 /team/group/media_formats-reviewed-trunk/codecs/codec_dahdi.c 418654 /team/group/media_formats-reviewed-trunk/bridges/bridge_softmix.c 418654 /team/group/media_formats-reviewed-trunk/apps/app_mixmonitor.c 418654 /team/group/media_formats-reviewed-trunk/apps/app_jack.c 418654 Diff: https://reviewboard.asterisk.org/r/3787/diff/ Testing ------- Thanks, rmudgett
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
