----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3786/#review12644 -----------------------------------------------------------
Ship it! Ship It! - Matt Jordan On July 14, 2014, 5:46 p.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3786/ > ----------------------------------------------------------- > > (Updated July 14, 2014, 5:46 p.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > When doing direct media the res_pjsip_sdp_rtp module negotiates using only > the media type of the specific stream. There is a function present which > removes formats of all other types. This incorrectly removes all formats by > accidentally using AST_MEDIA_TYPE_UNKNOWN. The patch fixes this so it does > not. > > > Diffs > ----- > > /team/group/media_formats-reviewed-trunk/res/res_pjsip_sdp_rtp.c 418612 > > Diff: https://reviewboard.asterisk.org/r/3786/diff/ > > > Testing > ------- > > Setup a call with a direct media bridge and confirmed no errors on console > and media going direct. Without this patch an error would come up complaining > about no compatible codecs. > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
