> On July 8, 2014, 6:52 p.m., Corey Farrell wrote: > > I just checked, the Makefile optionally includes makeopts. It is only > > optional so the Makefile can print a nice message that you need to > > ./configure. This file sets DAHDI_INCLUDE, checking that for non-blank in > > addition to the check for --prefix would make me very happy. In general > > people aren't going to install the dahdi development package then choose to > > not build chan_dahdi.
DAHDI_INCLUDE gets an empty value on my system (that builds chan_dahdi). I can't see any other way for the makefile to see the result of PBX_DAHDI from autoconf (except a direct sed from build_tools/menuselect-deps). - Tzafrir ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3727/#review12513 ----------------------------------------------------------- On July 8, 2014, 3:37 p.m., Tzafrir Cohen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3727/ > ----------------------------------------------------------- > > (Updated July 8, 2014, 3:37 p.m.) > > > Review request for Asterisk Developers and Corey Farrell. > > > Repository: Asterisk > > > Description > ------- > > Commit r417863 added support for installing a hook script for dahdi under > /usr/share/dahdi/span_config.d . This, however, broke support for users > setting --prefix=$HOME: > > /usr/bin/install -c -d //usr/share/dahdi/span_config.d > /usr/bin/install: cannot create directory ‘//usr/share/dahdi’: Permission > denied > > Suggested fix: only install the hook prefix is /usr. > > Note: installing only if chan_dahdi was enabled is not easy as > menuselect.makeopts is not included into the main Makefile. > > > Diffs > ----- > > /trunk/Makefile 418065 > > Diff: https://reviewboard.asterisk.org/r/3727/diff/ > > > Testing > ------- > > > Thanks, > > Tzafrir Cohen > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
