----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3494/#review11814 -----------------------------------------------------------
/branches/12/main/stasis_user.c <https://reviewboard.asterisk.org/r/3494/#comment21663> Wrapping the snapshots is fine, but I think all you'll need is the type stored as an enum. That will allow something converting the snapshots into another format to know how to convert them. /branches/12/main/stasis_user.c <https://reviewboard.asterisk.org/r/3494/#comment21662> I'd go with a different approach for storing the various snapshots. An ao2 container, while useful if you want to look up a single particular object, is overkill when the pattern of usage is to iterate over the entire container. Generally, payloads are always consumed in whole - it's rare for anyone to only want a single part of the payload. This is particularly true for payloads with multiple objects: you generally will convert all of the objects in it to JSON, or AMI kvp, or something else. I'd just store the snapshots in a wrapped struct (like you have) that is a tuple of (type, snapshot) in a list or a vector. That has the added benefit of not requiring a custom hash function. - Matt Jordan On April 29, 2014, 11:15 a.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3494/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 11:15 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-22697 > https://issues.asterisk.org/jira/browse/ASTERISK-22697 > > > Repository: Asterisk > > > Description > ------- > > This changes the implementation of UserEvent stasis messaging and adds > additional features: > > 1) Existing channel_user_event stasis messaging replaced with new > multi_object_blob in stasis_user.c > 2) Multi object blob provides ability to signal blob + any number of channel, > bridge, or endpoint snapshots > 3) Changed existing Userevent() app to use new multi object blob - but still > publishes to channel > 4) Added ARI implementation of userevent as > /ari/applications/{applicationName}/user/{eventName} > 5) ARI generated userevent messages are published to application, and also to > AMI if channel present > > > Diffs > ----- > > /branches/12/rest-api/api-docs/events.json 413115 > /branches/12/rest-api/api-docs/applications.json 413115 > /branches/12/res/stasis/app.c 413115 > /branches/12/res/res_stasis.c 413115 > /branches/12/res/res_ari_applications.c 413115 > /branches/12/res/ari/resource_applications.c 413115 > /branches/12/res/ari/resource_applications.h 413115 > /branches/12/res/ari/ari_model_validators.c 413115 > /branches/12/res/ari/ari_model_validators.h 413115 > /branches/12/main/stasis_user.c PRE-CREATION > /branches/12/main/stasis_channels.c 413115 > /branches/12/main/manager_channels.c 413115 > /branches/12/main/asterisk.c 413115 > /branches/12/include/asterisk/stasis_user.h PRE-CREATION > /branches/12/include/asterisk/stasis_channels.h 413115 > /branches/12/include/asterisk/stasis_app.h 413115 > /branches/12/apps/app_userevent.c 413115 > > Diff: https://reviewboard.asterisk.org/r/3494/diff/ > > > Testing > ------- > > Tested with valgrind to insure no invalid references. Some leaks found which > have been attributed to other code to be fixed separately. > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
