> On April 17, 2014, 9:28 a.m., Matt Jordan wrote: > > Ship It!
For tracking purposes, please open an issue in the issue tracker for these improvements, and reference this review board post. Thanks! - Matt ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3430/#review11650 ----------------------------------------------------------- On April 16, 2014, 6:07 a.m., Peter Whisker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3430/ > ----------------------------------------------------------- > > (Updated April 16, 2014, 6:07 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > I have been actively testing Unistim devices (i2002 & i2004) and have > encountered issues with > 1) dialtone wrong > 2) inability to select DTMF playback duration > 3) inability to set date to match than of a Nortel CS1000 > 4) mute causing playback to be muted as well as microphone > 5) Timer displayed in French (Duree) > > The attached patch fixes as follows: > 1) The "modulation" should not be referenced for tone+tone as it refers to > the on-off characteristic I believe - this often resulted in a single tone > rather than the multitone as in the UK. > 2) I have added the unistim.conf variable dtmf_duration which can select the > DTMF playback duration from 0ms to 150ms (0 is off and is the new default) > 3) I have enabled the transmission of MonthLabels (in English) which are sent > with the date and changed the dateformat variable to accept the values 0-3 as > per the UNISTIM standard (2 & 3 match the previous 1 & 2 formats). > 4) I have enabled the "Mute" packet and merged it into the previous code. It > now only mutes the microphone. (Improvements welcome) > 5) Changed Duree to Timer on i2004 display > > > Diffs > ----- > > /trunk/configs/unistim.conf.sample 412191 > /trunk/channels/chan_unistim.c 412191 > /trunk/CHANGES 412191 > > Diff: https://reviewboard.asterisk.org/r/3430/diff/ > > > Testing > ------- > > In use here > > > Thanks, > > Peter Whisker > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
