----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/1392/#review11597 -----------------------------------------------------------
Ship it! /trunk/apps/app_sms.c <https://reviewboard.asterisk.org/r/1392/#comment21361> This NOTICE could probably be a bit clearer, but that can be cleaned up on commit. - Matt Jordan On Aug. 26, 2011, 10:16 p.m., dwmw2 wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/1392/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2011, 10:16 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-18331 > https://issues.asterisk.org/jira/browse/ASTERISK-18331 > > > Repository: Asterisk > > > Description > ------- > > Fix two problems with app_sms. > > Firstly, the 'flags' field on the stack in sms_exec() is uninitialised, > causing it to use the wrong protocol in some cases. > > Secondly, when disconnect supervision is not working or inbanddisconnect=yes > is set in chan_dahdi.conf, app_sms was failing to terminate the call after it > sent the REL(ease) message and the peer stopped talking to it. This patch > fixes the code to handle the 'bad stop bit' message more gracefully in that > case, and hang up the call. > > > Diffs > ----- > > /trunk/apps/app_sms.c 333428 > > Diff: https://reviewboard.asterisk.org/r/1392/diff/ > > > Testing > ------- > > Sending and receiving protocol 1 messages to/from British Telecom over ISDN > BRI (with chan_dahdi), both with and without inbanddisconnect=yes. > > > Thanks, > > dwmw2 > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
