----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3415/#review11570 -----------------------------------------------------------
Ship it! Only a minor technicality nit. branches/12/main/bridge.c <https://reviewboard.asterisk.org/r/3415/#comment21327> Though locking is not strictly necessary here, for completeness, lock the bridge before calling here to satisfy the pre condition. - rmudgett On April 4, 2014, 9:31 a.m., opticron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3415/ > ----------------------------------------------------------- > > (Updated April 4, 2014, 9:31 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-22904 > https://issues.asterisk.org/jira/browse/ASTERISK-22904 > > > Repository: Asterisk > > > Description > ------- > > While the vast majority of bridge snapshot creation is locked properly, there > are currently some instances that are not. This adds the missing locking to > ensure bridge state is not malleable during snapshot creation. > > > Diffs > ----- > > branches/12/tests/test_cel.c 411668 > branches/12/res/ari/resource_bridges.c 411668 > branches/12/main/bridge_basic.c 411668 > branches/12/main/bridge.c 411668 > branches/12/include/asterisk/stasis_bridges.h 411668 > branches/12/apps/app_confbridge.c 411668 > > Diff: https://reviewboard.asterisk.org/r/3415/diff/ > > > Testing > ------- > > Ran the testsuite to ensure that it did not cause failures. > > > Thanks, > > opticron > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
