----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3428/#review11540 -----------------------------------------------------------
/asterisk/trunk/tests/rest_api/bridges/playback/tones/bridges_play.py <https://reviewboard.asterisk.org/r/3428/#comment21282> This comment is really describing the purpose of this function. This should be a pydocs comment. This should be applied to the related comments in the other functions in this test. /asterisk/trunk/tests/rest_api/bridges/playback/tones/test-config.yaml <https://reviewboard.asterisk.org/r/3428/#comment21291> This should cover pause/unpause/restart as well. /asterisk/trunk/tests/rest_api/bridges/playback/tones/test-config.yaml <https://reviewboard.asterisk.org/r/3428/#comment21290> What reads the 'apps' tag? Shouldn't this be part of the ari-config section? /asterisk/trunk/tests/rest_api/bridges/playback/tones/test-config.yaml <https://reviewboard.asterisk.org/r/3428/#comment21284> You shouldn't be matching on blank fields. You should be matching on a regex of the expected bridge/channel, if possible. /asterisk/trunk/tests/rest_api/bridges/playback/tones/test-config.yaml <https://reviewboard.asterisk.org/r/3428/#comment21292> This should match on the playback object, much like the channels version of this test. /asterisk/trunk/tests/rest_api/bridges/playback/tones/test-config.yaml <https://reviewboard.asterisk.org/r/3428/#comment21285> Tones should go into 12.3.0 /asterisk/trunk/tests/rest_api/bridges/playback/tones/test-config.yaml <https://reviewboard.asterisk.org/r/3428/#comment21286> This is a bridge test, so you need dependencies other than just res_ari_channels /asterisk/trunk/tests/rest_api/playback/tests.yaml <https://reviewboard.asterisk.org/r/3428/#comment21288> From a test organization perspective, these tests should probably go under channels/playback. The other option would be to move all of the bridge playback tests here, and organize these as playback/channels/... and playback/bridges/... /asterisk/trunk/tests/rest_api/playback/tones/test-config.yaml <https://reviewboard.asterisk.org/r/3428/#comment21287> 12.3.0 /asterisk/trunk/tests/rest_api/playback/tones/test-config.yaml <https://reviewboard.asterisk.org/r/3428/#comment21289> Remove the commented out code - Matt Jordan On April 8, 2014, 6 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3428/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 6 p.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-23433 > https://issues.asterisk.org/jira/browse/ASTERISK-23433 > > > Repository: testsuite > > > Description > ------- > > The YAML files have pretty apt descriptions. > > Channel version: > * Originate a channel > * Playback a tone > * Pause it > * Unpause it > * Restart it > * Delete the tone playback > * Delete the channel > * Validate all the events > > Bridge version: > * Originate a channel > * Create a bridge > * Add the channel to the bridge > * Start a tone playback on the bridge > * Delete the tone playback > * Delete the channel > * Validate all the events > > > Diffs > ----- > > /asterisk/trunk/tests/rest_api/playback/tones/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/rest_api/playback/tones/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/rest_api/playback/tests.yaml 4944 > /asterisk/trunk/tests/rest_api/bridges/tests.yaml 4944 > /asterisk/trunk/tests/rest_api/bridges/playback/tones/test-config.yaml > PRE-CREATION > > /asterisk/trunk/tests/rest_api/bridges/playback/tones/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/rest_api/bridges/playback/tones/bridges_play.py > PRE-CREATION > /asterisk/trunk/tests/rest_api/bridges/playback/tests.yaml PRE-CREATION > /asterisk/trunk/tests/rest_api/bridges/bridge_play/test-config.yaml 4944 > > /asterisk/trunk/tests/rest_api/bridges/bridge_play/configs/ast1/extensions.conf > 4944 > /asterisk/trunk/tests/rest_api/bridges/bridge_play/bridges_play.py 4944 > > Diff: https://reviewboard.asterisk.org/r/3428/diff/ > > > Testing > ------- > > Ran tests, varied results, the usual. They aren't especially changed from > the tests they are based on (in each case there is an existing baseline test > in the same folder which handles sounds). > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
