----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3427/#review11534 -----------------------------------------------------------
/trunk/CHANGES <https://reviewboard.asterisk.org/r/3427/#comment21274> Go ahead and do this patch against 12. This CHANGES notice should be put into the section for 12.3.0 /trunk/main/app.c <https://reviewboard.asterisk.org/r/3427/#comment21269> This should return an integer, as starting the tones can fail. /trunk/main/app.c <https://reviewboard.asterisk.org/r/3427/#comment21267> This would be an appropriate place for a ternary operator: ast_playtones_start(chan, 0, ts ? ts->data : tone, 0); You also need to check for success/failure here. If the start function fails, bail immediately. /trunk/main/app.c <https://reviewboard.asterisk.org/r/3427/#comment21270> I'm not sure you should be specifying a full second here. If I send the channel a control stream stop/restart/etc. frame, I don't want to wait a second before you process it. This should probably use ast_waitfor(chan, -1) and respond to any frame. /trunk/main/app.c <https://reviewboard.asterisk.org/r/3427/#comment21271> Capitalization please. "Media control operation 'reverse'..." /trunk/main/app.c <https://reviewboard.asterisk.org/r/3427/#comment21272> And here as well. /trunk/res/res_stasis_playback.c <https://reviewboard.asterisk.org/r/3427/#comment21273> Update the play operation documentation in channels and bridges json files with the new URI schema that is supported. - Matt Jordan On April 8, 2014, 5:46 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3427/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 5:46 p.m.) > > > Review request for Asterisk Developers, David Lee, Joshua Colp, and Matt > Jordan. > > > Bugs: ASTERISK-23433 > https://issues.asterisk.org/jira/browse/ASTERISK-23433 > > > Repository: Asterisk > > > Description > ------- > > Adds a tones URI type to the playback resource. The tone can be specified by > name (from indications.conf) or by a tone pattern (comma separate > pitch/duration list). Tones aren't like regular sounds in that they must be > canceled manually before the control can move on to the next item in the > queue. > > Tones are capable of being paused and resumed (although they will always > resumed from the beginning of the tone), restarted, and stopped. Tones are > not capable of being fastforwarded, skipped into by a duration, or rewound by > a small amount. Those operations unfortunately report success rather than a > lack of availability right now due to how control on playbacks is defined (a > playback is either completely controllable or not). I could probably add a > little more granularity to that if we want it. > > > Diffs > ----- > > /trunk/res/res_stasis_playback.c 411884 > /trunk/main/app.c 411884 > /trunk/include/asterisk/app.h 411884 > /trunk/CHANGES 411884 > > Diff: https://reviewboard.asterisk.org/r/3427/diff/ > > > Testing > ------- > > I've written two testsuite tests (one for channels, one for bridges) which > queue and stop tones with playback. I'll be posting them before too long. > I've also performed all the basic control operations by hand. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
