----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/#review11298 -----------------------------------------------------------
Ship it! /team/group/media_formats-reviewed/include/asterisk/codec.h <https://reviewboard.asterisk.org/r/3319/#comment20940> Kind of a nitpick, but for this and ast_format_determine_length(), the word "determine" is out of place. Just a simple "get" works better. - Mark Michelson On March 20, 2014, 11:40 a.m., Joshua Colp wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3319/ > ----------------------------------------------------------- > > (Updated March 20, 2014, 11:40 a.m.) > > > Review request for Asterisk Developers. > > > Repository: Asterisk > > > Description > ------- > > Through implementing things some additional functionality needed to be > added/tweaked. This does so. > > > Diffs > ----- > > /team/group/media_formats-reviewed/main/format_cap.c 410188 > /team/group/media_formats-reviewed/main/format.c 410186 > /team/group/media_formats-reviewed/main/codec.c 410188 > /team/group/media_formats-reviewed/include/asterisk/frame.h 410188 > /team/group/media_formats-reviewed/include/asterisk/format_cap.h 410188 > /team/group/media_formats-reviewed/include/asterisk/format_cache.h 410189 > /team/group/media_formats-reviewed/include/asterisk/format.h 410186 > /team/group/media_formats-reviewed/include/asterisk/codec.h 410188 > /team/group/media_formats-reviewed/include/asterisk/callerid.h 409286 > > Diff: https://reviewboard.asterisk.org/r/3319/diff/ > > > Testing > ------- > > > Thanks, > > Joshua Colp > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
