----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3371/ -----------------------------------------------------------
(Updated March 18, 2014, 5:11 p.m.) Review request for Asterisk Developers. Changes ------- * Made ast_unreal_new_channels() generate the ;2 uniqueid on a stack variable instead of mallocing it. * Fixed minor hole in generating the ;2 uniqueid string length. * Created public and internal lengths of uniqueid. The internal length can handle a max public uniqueid plus an appended ;2. * Made ast_channel_internal_set_fake_ids() use the safer ast_copy_string(). Repository: Asterisk Description ------- Miscellaneous uniqueid cleanups and fixes. * Fix memory leak in ast_unreal_new_channels(). * Made send error response in ARI and AMI instead of just logging excessive uniqueid length. action_originate() and ari_channels_handle_originate_with_id(). * free() and ast_free() are NULL tolerant so they don't need a NULL test before calling. * Made use better struct initialization format instead of position dependent initialization format. Also anything not explicitly initialized in the struct is initialized to zero by the compiler. Diffs (updated) ----- /branches/12/res/res_stasis_snoop.c 410875 /branches/12/res/ari/resource_channels.c 410875 /branches/12/main/manager.c 410875 /branches/12/main/dial.c 410875 /branches/12/main/core_unreal.c 410875 /branches/12/main/channel_internal_api.c 410875 /branches/12/include/asterisk/rtp_engine.h 410875 /branches/12/include/asterisk/channel.h 410875 Diff: https://reviewboard.asterisk.org/r/3371/diff/ Testing ------- Compiler blessed and code inspection. Thanks, rmudgett
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
