----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3261/#review10945 -----------------------------------------------------------
Ship it! This was already covered in a previous UPGRADE note as well. I agree; I'd block changes at trunk. - Matt Jordan On Feb. 24, 2014, 5:25 p.m., Corey Farrell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3261/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2014, 5:25 p.m.) > > > Review request for Asterisk Developers and Matt Jordan. > > > Bugs: ASTERISK-23231 > https://issues.asterisk.org/jira/browse/ASTERISK-23231 > > > Repository: Asterisk > > > Description > ------- > > Change minrate from 2400 to 4800 on config reload in response to changes from > ASTERISK-22790 only. Any config with minrate of 2400 that would fail before > r405693 will still fail. > > Comment out many settings in res_fax.conf.sample. The defaults are set in > res_fax.c, so setting the same value in sample config does nothing but make > the sample config more fragile. > > I'm proposing the changes to res_fax.conf for all branches and trunk. I > believe the changes to res_fax.c should be blocked from trunk. > > > Diffs > ----- > > /branches/1.8/res/res_fax.c 408784 > /branches/1.8/configs/res_fax.conf.sample 408784 > > Diff: https://reviewboard.asterisk.org/r/3261/diff/ > > > Testing > ------- > > > Thanks, > > Corey Farrell > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
