----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3076/#review10443 -----------------------------------------------------------
Ship it! Ship It! - rmudgett On Dec. 18, 2013, 12:10 a.m., Scott Griepentrog wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3076/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2013, 12:10 a.m.) > > > Review request for Asterisk Developers. > > > Bugs: ASTERISK-22942 > https://issues.asterisk.org/jira/browse/ASTERISK-22942 > > > Repository: Asterisk > > > Description > ------- > > Reviewing the original submission of this code, r339465 > (https://reviewboard.asterisk.org/r/1116/), it would appear that in > fax_detect_framehook() the code block commented /* only handle VOICE and > CONTROL frames */ that the intent of the original author was to stop > processing (thus limiting overhead) of frames when certain no-go conditions > where met. These include unsupported formats, and unsupported frame types. > A check for no dsp is made, but curiously drops to the next code block on a > break. This patch constitutes my reinterpretation of the original authors > intent of this work, specifically, stop processing the frame (by returning > it) when no dsp is present. > > > Diffs > ----- > > /branches/11/res/res_fax.c 404041 > > Diff: https://reviewboard.asterisk.org/r/3076/diff/ > > > Testing > ------- > > > Thanks, > > Scott Griepentrog > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
