> On Dec. 6, 2013, 8:45 p.m., Mark Michelson wrote: > > On the one hand, using AppTest for this set of tests seems like an > > overly-complicated approach to use, but on the other hand, it works, so > > it's fine by me. > > > > Only reason I'm not putting a "Ship it!" on this review is that I want to > > be sure that the old page test hasn't been outright removed but just moved > > somewhere. It may be a quirk of review board or you may have purposely not > > included the old test since it is not relevant, but since it's not here I > > just wanted to make sure it hadn't disappeared.
Well, I svn moved it into page/page_baseline. I'm not entirely sure why the diff didn't include the moved files. It seems to be an SVN problem on my part rather than a reviewboard issue. I'll fix it up. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/#review10321 ----------------------------------------------------------- On Dec. 5, 2013, 11:36 p.m., Jonathan Rose wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviewboard.asterisk.org/r/3053/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 11:36 p.m.) > > > Review request for Asterisk Developers, Mark Michelson, opticron, and > rmudgett. > > > Repository: testsuite > > > Description > ------- > > Pretty straightforward. Tests that predial handlers are applied on the > appropriate channels when app_page uses the predial options. See the test > yaml for a slightly more in depth description. > > > Diffs > ----- > > /asterisk/trunk/tests/apps/tests.yaml 4397 > /asterisk/trunk/tests/apps/page/test-config.yaml 4397 > /asterisk/trunk/tests/apps/page/run-test 4397 > /asterisk/trunk/tests/apps/page/page_predial/test-config.yaml PRE-CREATION > /asterisk/trunk/tests/apps/page/page_predial/configs/ast1/extensions.conf > PRE-CREATION > /asterisk/trunk/tests/apps/page/configs/ast1/iax.conf 4397 > /asterisk/trunk/tests/apps/page/configs/ast1/extensions.conf 4397 > /asterisk/trunk/tests/apps/page/configs/ast1/amd.conf 4397 > > Diff: https://reviewboard.asterisk.org/r/3053/diff/ > > > Testing > ------- > > It runs and it doesn't fail with the patch applied. It does without the > patch applied. I checked through logs to make sure channels hit everything > in the PBX as expected. > > > Thanks, > > Jonathan Rose > >
-- _____________________________________________________________________ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
