On Tue, Oct 30, 2007 at 10:13:56AM -0500, Kevin P. Fleming wrote:
> SVN commits to the Asterisk project wrote:
> > Author: rizzo
> > Date: Tue Oct 30 09:57:19 2007
> > New Revision: 87533
> >
> > URL: http://svn.digium.com/view/asterisk?view=rev&rev=87533
> > Log:
> > remove some useless arguments from internal stringfield calls:
> > the number of entries is only needed in a small number of places.
> >
> > This is a trunk candidate, together with followup cleanups to this code.
>
> Please don't do this; it is doubtful (at best) that any other developer
> is going to troll through your commits looking for your 'trunk
> candidates' and merge them for you.
>
> You have commit access to trunk, please make the changes directly there
> if you feel they are worth making.
I intend to merge them myself, but first want to give a chance to people
to revise and comment. My plan is:
+ make small incremental commits to a private branch;
+ once i am done, write an email to -dev with a list of proposed changes
(referencing the commits);
+ give a bit of time to others (and myself, too) to review them;
+ if no complaints, merge to trunk; otherwise, discuss.
makes sense ?
cheers
luigi
_______________________________________________
--Bandwidth and Colocation Provided by http://www.api-digital.com--
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
