On Thursday 25 October 2007 10:30:20 Kevin P. Fleming wrote: > Since all this stuff is in the global namespace, it should be prefixed > with ast_ so as not to collide with anything defined locally in modules. > Also, I'd suggest prefixing the two callback functions with '__ast_', > signifying that they are for internal usage only and should not be > called directly. > > Another possibility would be to move the definition of the > dialed_interface_info structure into global_datastores.c, and leaving > just an 'extern' declaration of it in this header file. This would allow > these two functions to then be static and local to that module.
Generally speaking, none of the datastore structures or functions should be in the global namespace. There is almost always a better way that hides the implementation details of the datastore from the functionality we're implementing. -- Tilghman _______________________________________________ --Bandwidth and Colocation Provided by http://www.api-digital.com-- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
