Kevin P. Fleming wrote: > SVN commits to the Asterisk project wrote: > > >> + if (update_cdr && qe->chan->cdr) >> + ast_copy_string(qe->chan->cdr->dstchannel, >> member->membername, sizeof(qe->chan->cdr->dstchannel)); >> > > This is buggy; member->membername could be an empty string, it is only > populated if a member name is specified. For static members there is no > membername, and so if 'updatecdr' is enabled this will result in a > broken CDR entry. > > This code either needs to use member->interface if member->membername is > empty, or we need to simplify the code in app_queue and just populate > ->membername with a copy of ->interface if no member name is provided > when the member is added to the queue. > > Correct me if I'm wrong, but I believe that the membername field of a member will be set to it's interface if no name is specified. There may be some exception, but I'm pretty certain this happens for all types of members.
Mark! _______________________________________________ Sign up now for AstriCon 2007! September 25-28th. http://www.astricon.net/ --Bandwidth and Colocation Provided by http://www.api-digital.com-- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
