On Mon, Jan 23, 2023 at 6:05 PM Genes Lists <li...@sapience.com> wrote:

>
> For what it's worth - on a machine with nvme I don't see
> shutdown_timeout in either
>
> $ ls /sys/module/nvme/parameters/
> or
> $ modinfo nvme
>
> So that's mildly interesting :)
> Not that it matters here, but I build nvme into my kernels rather than
> as a dynamic loaded module like arch kernels do.
>
>
Interesting on the loaded modules, since there are both nvme and nvme_core,
if you do:

$ modinfo nvme | grep timeout
$

Nothing - but if you do:

$ modinfo nvme_core | grep timeout
parm:           admin_timeout:timeout in seconds for admin commands (uint)
parm:           io_timeout:timeout in seconds for I/O (uint)
parm:           shutdown_timeout:timeout in seconds for controller shutdown
(byte)
parm:           apst_primary_timeout_ms:primary APST timeout in ms (ulong)
parm:           apst_secondary_timeout_ms:secondary APST timeout in ms
(ulong)

it does have the shutdown timeout parameter.

So presumably nvme_core.shutdown_timeout is the right way to set a value,
either as command line option (needed when nvme is builtin)
or using a file as /etc/modprobe.d/xxx if dynamic loaded.

mike

-- 
mike c

Reply via email to