Seems that you're right. I may have uncovered a bug in 1.4.1RC.
I modified the Ant source code to output the command line it was calling javac with, and it calls javac with a space delimited list of every class to compile. Using that same command line from a dos prompt and invoking javac, I was getting the same errors. Seems the bug is that 1.4.1RC javac _will_ compile a single class with a single-line comment followed by EOF. But it _won't_ compile more than one, it spits out the "unclosed comment" errors. So there ya go! It's a jdk bug, not an ant bug, and I will attempt to report it to the RC team (not sure how to do that yet). Ian. ----- Original Message ----- From: "Paul Christmann" <[EMAIL PROTECTED]> To: "'Ant Users List'" <[EMAIL PROTECTED]> Sent: Thursday, September 05, 2002 4:34 PM Subject: RE: "Unclosed comment" error with jdk1.4.1 while compiling > > ----- Original Message ----- > > From: "Ian Zabel" <[EMAIL PROTECTED]> > > > This is just a legacy coding convention that is in about > > 300 classes. When > > > compiling these classes with jdk1.4.1 RC from the command > > line, they all > > > compile fine. It's only a problem when compiling through ant, while > > running > > > on jdk1.4.1 RC. If we run ant with jdk1.4.0, it works fine too. > > If true (compiles with jdk1.4.1 RC on the command line), that is a > problem with *command line compilation*, not ant compilation. Ant is > behaving *as it should* with jdk1.4.1 RC -- barfing on the > EOF-terminated comments. This was an intentional change to jdk1.4.1. > I've encountered this same issue with some other open source projects I > use. Eventually, we backed down from jdk1.4.1 to 1.4.0 due to this > problem (I didn't have the time to patch several hundred files), > thinking/hoping someone else would eventuall do it. :) > > Buried in some docs at Suns web site > (http://java.sun.com/features/2002/08/java141.html) I found a very very > very brief reference to this: > > "Probably the most interesting changes are those made to the compiler > itself. <snip/> Fixes pertain to such illegal code as doubly labeled > loops, *** single-line comments that end with end-of-file instead of > end-of-line ***, and inner superclass constructor calls. See the Release > Notes for more details about these fixes." > > Side note: I've heard rumors that this change may get revoked (jdk1.4.1 > may allow EOF terminated comments and the JLS updated), so I'm sitting > on 1.4.0 until the next 1.4.1 release comes out. > > Paul Christmann > > > -- > To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> > For additional commands, e-mail: <mailto:[EMAIL PROTECTED]> > > -- To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]> For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
