On Saturday, February 22, 2014 7:07:23 AM UTC-8, Michael DeHaan wrote:
>
> "Don't you think that at some point it would be useful to support 
> different logging levels? Most systems have them."
>
> The no_log directive deals with invocation logging on the remotes only.
>
> There is *MUCH* more data logged on the server.
>
>
>
Just my two cents...  assuming that no_log is a boolean and defaults to 
false, I don't find it too confusing to have a no_log: true applied in 
specific tasks when you want to turn logging off.  no_log: false would only 
be used by people who want to be explicit or thinking that they might want 
to flip it at some point.  The double negative does not cause me any 
heartache (not that it would matter if it did).  If enough people hated it 
then a log: boolean option would work just as well but you would want to 
default it to true... and be careful because the name sounds like it could 
be the name of a module (like debug?) and that could cause confusion.  

log level is not something that I would (personally) want set at the module 
or task level.  I would personally think that the modules should know what 
they want to log and realistically should include a level in the log 
message (like syslog does) so that all log messages are sent back (saves 
extra logic in the modules) and they can be filtered by the receiver.  But 
we already have some of that (most maybe) with -vvvv...

In other words.  I like the no_log: option but see no reason to be able to 
modify log levels at anything lower than the reporting level.

Adam

-- 
You received this message because you are subscribed to the Google Groups 
"Ansible Project" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/ansible-project/6758315d-ff83-4ee7-b635-33b1fea82927%40googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reply via email to