Hi Chris, We've got a very large backlog due to massive levels of interest in Ansible and are working through the pull request queue. It may be some time before we get to this one, and I can't make assurances that this will be in 1.5.
It should probably not have it's own class to just define a static method, but rather a function within LinuxNetwork. You should also implement the check as requested to see if the file does not exist and return. You could also check in advance if the file was readable too. try/except logic makes the code less explicit. If we can anticipate an error and know when it will happen we always check for the error first. I think if we can't read it we should also set the return to None versus empty list. On Wed, Feb 5, 2014 at 1:50 PM, Christopher O'Connell <[email protected]>wrote: > Hi Michael, > > Can you just give me a little quick feedback on > https://github.com/ansible/ansible/pull/5508 > > If you still want me to make a change to the patch, I want to get it in > for 1.5. If you're good with it as is, please let me know. > > All the best, > > ~ Christopher > > -- > You received this message because you are subscribed to the Google Groups > "Ansible Project" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To post to this group, send email to [email protected]. > For more options, visit https://groups.google.com/groups/opt_out. > -- You received this message because you are subscribed to the Google Groups "Ansible Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
