Great ! thanks for patching it. On Wednesday, December 22, 2021 at 3:26:04 AM UTC+5:30 Dan Willemsen wrote:
> It appears that make & ckati both treat that as "" == "," (when > $(TARGET_BUILD_VARIANT) is `user`), so that case never triggers. > > I've posted a removal of the second comma here: > https://android-review.googlesource.com/c/platform/build/+/1931200/ > > Thanks, > Dan > > > > On Tue, Dec 21, 2021 at 1:10 PM Abhayadev S <[email protected]> wrote: > >> Hi, >> >> I see the following in the build/make/core/product_config.mk >> <https://cs.android.com/android/platform/superproject/+/master:build/make/core/product_config.mk;drc=f1f49bb9101448bd6b508625b1eae0ae30e127fa;l=415> >> >> ifeq (,$(filter eng userdebug,$(TARGET_BUILD_VARIANT)),) >> >> here ifeq has been given with 3 arguments right? is it expected? what >> will be the outcome? >> >> regards, >> abhay >> >> -- >> -- >> You received this message because you are subscribed to the "Android >> Building" mailing list. >> To post to this group, send email to [email protected] >> To unsubscribe from this group, send email to >> [email protected] >> For more options, visit this group at >> http://groups.google.com/group/android-building?hl=en >> >> --- >> You received this message because you are subscribed to the Google Groups >> "Android Building" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/android-building/d1a1280f-8c6b-42c1-b384-1e12f1282c8an%40googlegroups.com >> >> <https://groups.google.com/d/msgid/android-building/d1a1280f-8c6b-42c1-b384-1e12f1282c8an%40googlegroups.com?utm_medium=email&utm_source=footer> >> . >> > -- -- You received this message because you are subscribed to the "Android Building" mailing list. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/android-building?hl=en --- You received this message because you are subscribed to the Google Groups "Android Building" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/android-building/a2b44db3-0326-48d2-a336-eb378e155035n%40googlegroups.com.
