How are you getting the benchmarks on to the device? In my testing (`m libjavacore-benchmarks`, `adb sync data` they are marked executable.
On Fri, Oct 11, 2019 at 10:49 AM Paul Elliott <[email protected]> wrote: > Hi Colin, > > The curious bit is that even as root I am having to change the tests > inside benchmarktest(64) to be executable because they too have no > permissions, which is why I was curious about this as it clearly breaks > automation for us, and therefore likely for anyone else. We could > potentially submit a patch for this to add the directory to fs_config.cpp, > however given the lack of mention by anyone else, was unsure if we were > missing something, basically. > > Paul. > > On Thursday, October 10, 2019 at 9:12:11 PM UTC+1, Colin Cross wrote: >> >> Likely an oversight. It has been this way for benchmarks defined in Make >> since 2016. Maybe the benchmark test runners are running as root? >> >> On Thu, Oct 10, 2019 at 10:22 AM Paul Elliott <[email protected]> wrote: >> >>> Hi all, >>> >>> Prior to android 9, all benchmarks and test suites were generally built >>> into /data/nativetest(64), however recently in Android 9, some (but not >>> all) tests have been ending up getting built into /data/benchmarktest(64), >>> due to a change aligning soong with make - >>> https://android-review.googlesource.com/c/platform/build/soong/+/479681 >>> >>> This would be fine, however due to its lack of inclusion >>> in system/core/libcutils/fs_config.cpp, this folder is created without any >>> permissions whatsoever. >>> >>> I have checked this is still the case in Android 10, and indeed master. >>> Is this an oversight, or am I missing something? >>> >>> Thanks in advance, >>> >>> Paul. >>> >>> -- >>> -- >>> You received this message because you are subscribed to the "Android >>> Building" mailing list. >>> To post to this group, send email to [email protected] >>> To unsubscribe from this group, send email to >>> [email protected] >>> For more options, visit this group at >>> http://groups.google.com/group/android-building?hl=en >>> >>> --- >>> You received this message because you are subscribed to the Google >>> Groups "Android Building" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected]. >>> To view this discussion on the web visit >>> https://groups.google.com/d/msgid/android-building/989e4b75-4366-4b18-b534-dd12f2c022a4%40googlegroups.com >>> <https://groups.google.com/d/msgid/android-building/989e4b75-4366-4b18-b534-dd12f2c022a4%40googlegroups.com?utm_medium=email&utm_source=footer> >>> . >>> >> -- > -- > You received this message because you are subscribed to the "Android > Building" mailing list. > To post to this group, send email to [email protected] > To unsubscribe from this group, send email to > [email protected] > For more options, visit this group at > http://groups.google.com/group/android-building?hl=en > > --- > You received this message because you are subscribed to the Google Groups > "Android Building" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > To view this discussion on the web visit > https://groups.google.com/d/msgid/android-building/fce01460-04f9-49a1-b73b-f4c89c8a4ab4%40googlegroups.com > <https://groups.google.com/d/msgid/android-building/fce01460-04f9-49a1-b73b-f4c89c8a4ab4%40googlegroups.com?utm_medium=email&utm_source=footer> > . > -- -- You received this message because you are subscribed to the "Android Building" mailing list. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/android-building?hl=en --- You received this message because you are subscribed to the Google Groups "Android Building" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/android-building/CAMbhsRSUvHonrEz3eoUPi%2Bj%2B3uSsqJE2gVFyq7s3PABrYs-xiw%40mail.gmail.com.
